Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gnodev): lazy loading & staging support #3237

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

feat(gnodev): lazy loading & staging support #3237

wants to merge 35 commits into from
+3,000 −968

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Nov 28, 2024 •
edited
Loading

featuring:

  • Lazy reload: Super fast reload, only loading the needed packages for the current directory package.
  • Chain resolver: You can change the gnodev resolving process so it can resolve packages on-chain and configure a local fallback, allowing you to try your package against the chain before submitting it.
  • Staging Mode: gnodev now starts from the current directory by default. The staging subcommand will reproduce previous behaviors by loading and monitoring the entire example folder.
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@gfanton gfanton self-assigned this Nov 28, 2024
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.21596% with 569 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ontribs/gnodev/pkg/packages/resolver_middleware.go 0.98% 100 Missing and 1 partial ⚠️
contribs/gnodev/pkg/packages/package.go 0.00% 84 Missing ⚠️
contribs/gnodev/pkg/proxy/path_interceptor.go 58.22% 53 Missing and 13 partials ⚠️
contribs/gnodev/pkg/packages/resolver_remote.go 0.00% 63 Missing ⚠️
contribs/gnodev/pkg/packages/loader.go 0.00% 62 Missing ⚠️
contribs/gnodev/pkg/packages/loader_glob.go 0.00% 47 Missing ⚠️
contribs/gnodev/pkg/packages/resolver.go 0.00% 32 Missing ⚠️
contribs/gnodev/pkg/dev/query_path.go 0.00% 30 Missing ⚠️
contribs/gnodev/pkg/packages/resolver_mock.go 0.00% 19 Missing ⚠️
contribs/gnodev/pkg/packages/glob.go 86.04% 16 Missing and 2 partials ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

@gfanton
chore: fixup
fd13a5a 
Signed-off-by: gfanton <[email protected]>
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 30, 2024 •
edited
Loading

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@gfanton gfanton force-pushed the feat/dev/lazy-loader branch from 5b95a3e to 135f854 Compare November 30, 2024 08:13
@gfanton
wip: lazy loader
d258fd5 
Signed-off-by: gfanton <[email protected]>
@gfanton
wip: test
3f92248 
Signed-off-by: gfanton <[email protected]>
@gfanton
wip: staging
3e9c300 
Signed-off-by: gfanton <[email protected]>
@gfanton
Merge remote-tracking branch 'origin/master' into feat/dev/lazy-loader
07c714a 
Signed-off-by: gfanton <[email protected]>
@gfanton
wip: glob
0e5e5f0 
Signed-off-by: gfanton <[email protected]>
@gfanton
feat: staging
54c8193 
Signed-off-by: gfanton <[email protected]>
@gfanton
feat: gnodev app
ec51f78 
Signed-off-by: gfanton <[email protected]>
@gfanton
chore: lint
d48ffd9 
Signed-off-by: gfanton <[email protected]>
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Dec 15, 2024
@gfanton
fix: web redirect
b193081 
Signed-off-by: gfanton <[email protected]>
@gfanton
fix: minor fix
6ef3685 
Signed-off-by: gfanton <[email protected]>
@leohhhn leohhhn self-requested a review December 16, 2024 10:02
@gfanton gfanton changed the title wip(gnodev): lazy loading & staging support feat(gnodev): lazy loading & staging support Jan 9, 2025
gfanton added 3 commits January 9, 2025 16:40
@gfanton
fix: globl package
5fb70a9 
Signed-off-by: gfanton <[email protected]>
@gfanton
chore: lint
09ea7cc 
Signed-off-by: gfanton <[email protected]>
@gfanton
fix: tests
8b7a457 
Signed-off-by: gfanton <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2025
View reviewed changes
contribs/gnodev/pkg/packages/glob.go Dismissed Show dismissed Hide dismissed
@gfanton gfanton marked this pull request as ready for review January 9, 2025 15:49
@zivkovicmilos zivkovicmilos self-requested a review January 9, 2025 15:53
@leohhhn
Copy link
Contributor

leohhhn commented Jan 12, 2025 •
edited
Loading

Playing around now; will note some things I notice.

I noticed there is a 1-2s delay between the node having reloaded and gnoweb actually displaying a render change. solved

@Kouteki Kouteki added the in focus Core team is prioritizing this work label Jan 13, 2025
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leohhhn leohhhn Awaiting requested review from leohhhn

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

At least 1 approving review is required to merge this pull request.

Assignees

@gfanton gfanton

Labels
in focus Core team is prioritizing this work 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
🧙‍♂️gno.land core team
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gfanton @Gno2D2 @leohhhn @Kouteki